Addition of a sub-leader rank for royals

This is what happens when I tried

Blehh

Ty

Did some additional testing on this as well. Looks like we probably need to make a few adjustments to it:

• Changing someones rank from Probation to Normal has text saying "You've changed [x] rank to Apprenticeship" and lists it as MEMBER in the pledge list window. Probably should uniform this.
• Same as above for Probation, it you try to change it back to Probation it gives the same "You've changed [x] rank to Apprentice" text and continues to list it as MEMBEr in the pledge list window.
• Did confirm the same issue that Utopian ran into with it just saying "Guardian" when trying the subleader rank. Also tested to see if it had the ability to accept members into the pledge, but it did not so assuming that the subleader permissions probably didn't take either.

I tested also, and no, subleader permissions are not active

Also, if you notice, there is an extra ) in the /rank help message right after subleader

I dont know if that means anything

( starts before the word Probation

ty for trying my head is spinning

ok understood everything that was written

applied 2 more patches, fingers crossed

ok not good, but maybe subleader cant be added this way

and i have to do a -subleader <name> command instead for this server pack/client

I wonder how justice does it

they can do it with /rank ?

Yes

I can show you a video or snapshot of it

oh im jealous now

If a vid would help

no i just dont know how to do it

can you make someone a subleader who is , say, normal

or do they have to be a guardian first

No. I can make them subleader from go

ok ty

-subleader command looks to work

I’ll give it a try tonight

subleader didnt allow titles to be given and it locked subleaders out of BP storage

Just put this on the backburner for now, its not that important. you have siege stuff to figure out

🇩 - Moving over to in-development in the meantime.

I would disable -subleader till it’s right

patched a long time ago i think but never tried

Almost there with this one Meph! Tested a few things:

• Using the -subleader command does actually change rank in /pledge of the member AND they do see the /pledge screen as a royal does.
• Tested /join as a sub-leader, that also works.
• What doesn't work with Subleader is what UTOPIAN mentioned, they can't give titles, but they can retrieve items from BP storage but cannot store them.
• If we have to use the -subleader command, we should remove the "Subleader" option from the /rank command, and just put a note in there when someone types /rank to use the command instead. Also we need to update /?page=pledge-guide once fixed.

Declaring war obviously needs to stay with the royal, but since they can allow members in, do we want to allow sub-leaders to also kick members out?

Yes. Subleaders are just that. They can recruit, ban, title and rank other members who are lower rank than themselves.
Declaring and such is still a royal only as you mentioned

i dont remember what i patched after seeing this

First thing I noticed was subleader takes BP storage access away.
That is an issue.

possibly title related

patching ty

🇹 - This one should be live now! Moving over to testing, will test when I can.

@Mephi - Just tested these out and not sure the last patches took on the last restart we did (not loaded into memory), here were my results:

• The -subleader command works fine, changes rank to Subleader.
• Sub-leaders can /join members.
• The /rank command for sub-leaders looks like it's going to work because it provides the syntax, but doesn't actually go through when you type in the rank.
• Sub-leaders can't /ban members.
• BP storage issue mentioned before is fixed.
• We also still need to update the pledge guide on website + the notes on the /rank command for using the -subleader command.

Adding @Dave Mack and @Zerick too for updates when this one gets patched